Specification of wall function treatment per individual marker #435
Conversation
There was a problem hiding this comment.
Looks good to me. Thanks for laying this out, Edwin, and I think it is general enough for the future.
Before merging, @GomerOfDoom: could you please address your comments in #399 as it pertains to this PR, or provide a review?
|
Paul and I talked about this yesterday and it could be that additional input parameters are required for at least some of the wall models. Those can be added to the input data for the wall function markers. @GomerOfDoom, and others, could you specify what additional input data is needed for some of the wall models? Edwin |
|
Hi All, We will at least need a way to specify wall model thickness (distance away from the wall at which we exchange information with the flow solver). I think it would also be good to be able to specify the number of wall model points (for a 1-D model) between the exchange location and the wall, the stretching factor, near-wall thickness, etc. -Paul |
|
Maybe it makes more sense to have this changes in a separate branch for now ? This way we avoid potential problems for others in case there are some modifications of this config option necessary during the final implementation of the wall functions. |
|
Tim, You're right. I thought it was an easy thing to do, such that both the FVM and DG-FEM solvers could use it. But it seems to be more complicated than I originally thought. So let's close this PR for now. Edwin |
|
Added the possibility to add additional information for some of the wall models as requested by @GomerOfDoom. I hope this is general enough. |
SU2_CFD/src/output_structure.cpp
Outdated
| @@ -4726,12 +4726,12 @@ void COutput::SetConvHistory_Body(ofstream *ConvHist_file, | |||
| Total_IDC = solver_container[val_iZone][FinestMesh][FLOW_SOL]->GetTotal_IDC(); | |||
| } | |||
|
|
|||
| if (inv_design) { | |||
| /* if (inv_design) { | |||
There was a problem hiding this comment.
Everything looks good, other than a couple things that are commented, like this 'inv_design' section. Was this intended?
There was a problem hiding this comment.
Yes, because this variable is not used and leads to a compiler warning. This was merged in earlier, but apparently was reverted by another PR.
There was a problem hiding this comment.
I can remove it, if you prefer.
SU2_CFD/src/output_structure.cpp
Outdated
| @@ -8038,12 +8038,12 @@ void COutput::SpecialOutput_SpanLoad(CSolver *solver, CGeometry *geometry, CConf | |||
| if (iSection == 0) { | |||
| Dihedral_Leading = atan((Zcoord_LeadingEdge_ - Zcoord_LeadingEdge) / (Ycoord_LeadingEdge_ - Ycoord_LeadingEdge))*180/PI_NUMBER; | |||
| Dihedral_Trailing = atan((Zcoord_TrailingEdge_ - Zcoord_TrailingEdge) / (Ycoord_TrailingEdge_ - Ycoord_TrailingEdge))*180/PI_NUMBER; | |||
| Dihedral = 0.5*(Dihedral_Leading + Dihedral_Trailing); | |||
| // Dihedral = 0.5*(Dihedral_Leading + Dihedral_Trailing); | |||
There was a problem hiding this comment.
Same here. This is to avoid a compiler warning, which was merged in earlier and reverted again. Again, it can be removed.
SU2_CFD/src/output_structure.cpp
Outdated
| } | ||
| else { | ||
| Dihedral_Leading = atan((Zcoord_LeadingEdge - Zcoord_LeadingEdge_) / (Ycoord_LeadingEdge - Ycoord_LeadingEdge_))*180/PI_NUMBER; | ||
| Dihedral_Trailing = atan((Zcoord_TrailingEdge - Zcoord_TrailingEdge_) / (Ycoord_TrailingEdge - Ycoord_TrailingEdge_))*180/PI_NUMBER; | ||
| Dihedral = 0.5*(Dihedral_Leading + Dihedral_Trailing); | ||
| // Dihedral = 0.5*(Dihedral_Leading + Dihedral_Trailing); |
There was a problem hiding this comment.
Same here. This is to avoid a compiler warning, which was merged in earlier and reverted again. Again, it can be removed.
There was a problem hiding this comment.
Great. Can you please remove these extra commented lines to keep it clean? Then it's all good to merge.
This PR implements the specification of a different wall function treatment per viscous wall marker. In the configuration file you do this as follows, where the default is NO_WALL_FUNCTION.
% Viscous wall markers for which wall functions must be applied. (NONE = no marker)
% Format: ( marker name, wall function type, ... )
MARKER_WALL_FUNCTIONS= ( airfoil, NO_WALL_FUNCTION )
You can determine the type of wall function treatment for a given marker by calling the function CConfig::GetWallFunction_Treatment. I put a dummy call in CNSSolver::BC_HeatFlux_Wall and CNSSolver::BC_Isothermal_Wall, as an example.
It is the intention that the branches feature_Wall_Functions and feature_hom_wallModel merge with this version and work out the actual implementation for the FV solver and DG-FEM solver, respectively.