Bug fixes... #427
Merged
Bug fixes... #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Aug 20, 2017
| * \param[in] val_Total_Custom_ObjFunc - Value of the total custom objective function. | ||
| * \param[in] val_weight - Value of the weight for the custom objective function. | ||
| */ | ||
| void SetTotal_Custom_ObjFunc(su2double val_total_custom_objfunc, su2double val_weight); |
There was a problem hiding this comment.
Thanks for adding the Custom_ObjFunc to the incompressible solver
ghost
reviewed
Aug 20, 2017
| @@ -689,7 +689,7 @@ CEulerSolver::CEulerSolver(CGeometry *geometry, CConfig *config, unsigned short | |||
| Total_CFx = 0.0; Total_CFy = 0.0; Total_CFz = 0.0; | |||
| Total_CT = 0.0; Total_CQ = 0.0; Total_CMerit = 0.0; | |||
| Total_MaxHeat = 0.0; Total_Heat = 0.0; Total_ComboObj = 0.0; | |||
| Total_CpDiff = 0.0; Total_HeatFluxDiff = 0.0; | |||
| Total_CpDiff = 0.0; Total_HeatFluxDiff = 0.0; Total_Custom_ObjFunc=0.0; | |||
ghost
reviewed
Aug 20, 2017
|
|
||
| help="output QUIET to log files", metavar="QUIET") | ||
| parser.add_option("-z", "--zones", dest="nzones", default="1", | ||
| help="Number of Zones", metavar="ZONES") |
There was a problem hiding this comment.
Why the number of zones is now an input of these scripts? I thought it was stored in the mesh information.
There was a problem hiding this comment.
We have this because the python scripts also need to know the number of zones in order to have to correct file names.
ghost
approved these changes
Aug 20, 2017
|
Thanks for fixing this. We can merge this in right away. |
talbring
approved these changes
Aug 20, 2017
|
Thanks for the quick reviews. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the incompressible discrete adjoint and python scripts, as well as new test cases for the incomp. primal and discrete adjoint.