The global ID for all elements is now stored in the primal grid struc… #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture (same idea/methods as the global ID at each vertex).
rsanfer
reviewed
Nov 30, 2016
| #ifdef HAVE_MPI | ||
| MPI_Barrier(MPI_COMM_WORLD); | ||
| #endif | ||
| for (unsigned long iElem = 0; iElem < geometry_container[ZONE_0][MESH_0]->GetnElem(); iElem++) |
There was a problem hiding this comment.
Just as a quick comment to remember to remove this before merging with develop.
rsanfer
reviewed
Nov 30, 2016
|
Yikes! Thanks for the comment.. thought I got that out of there. Uploading the fix, and if everything checks out ok, we'll merge this in right away. |
|
I think we're ready. If you give it a thumbs up after checking that it's working for you, @rsanfer, I'll merge it in. |
rsanfer
previously approved these changes
Dec 1, 2016
talbring
approved these changes
Dec 1, 2016
|
I added the value of the global (real) number of elements before the partitioning. I needed this for GlobalToLocal vectors and load of information from file. @economon, can you double check it's all fine with this? |
|
LGTM. Just updated with develop and will merge in if the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ture (same idea/methods as the global ID at each vertex). This is useful for finite element calculations in particular (FEA).
We will have to fast track this one, as it is needed for a paper. However, I wanted everybody to see the addition and have a chance to comment on it.
We'll plan to get the output and incompressible PRs in next.