Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update in grid deformation subroutines #278

Merged
2 commits merged into from
May 30, 2016
Merged

Major update in grid deformation subroutines #278

2 commits merged into from
May 30, 2016

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2016

Several bugs have been fixed in the grid deformation and the config file have been updated.

In particular, the inverse volume method uses now an element volume computed in ComputeDeforming_Element_Volume (not the incomplete determinant computed in FEM). fabs have been added to the determinant in the final evaluation of the FEM stiffness matrix (depending on the element orientation, the determinant was negative). The formulation Mu = E / (2.0_(1.0 + Nu)), Lambda = Nu_E/((1.0+Nu)_(1.0-2.0_Nu)) is used instead of the basic simplification Mu = E, Lambda = -E. We can recover that formulation using a large number for Nu (DEFORM_COEFF). The code has been simplified and that IO is now more clear.

I have performed some tests and large deformations are now possible.

However, systematic regression tests for grid deformation is required using all the different kinds of elements. I remember that T. Economon put together some basic grids to test the mesh deformation, we should use those to check that everything is working fine before closing the release.

@ghost ghost merged commit 4a5c9bc into develop May 30, 2016
@economon
Copy link
Member

Thanks for the fixes, Francisco. I'll be working to fix up the failing tests. I still have the old meshes you mention, so I can add those to the tests that we already have for mesh deformation with the RAE 2822 and ONERA M6.

@ghost ghost deleted the feature_MeshDef branch November 12, 2016 06:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants