Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary variables for CFluidScalar constructor #2357

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

Cristopher-Morales
Copy link
Contributor

Proposed Changes

Small cleaning of CFluidScalar Constructor

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [ X] I am submitting my contribution to the develop branch.
  • [ X] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • [ X] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@Cristopher-Morales Cristopher-Morales changed the title [WIP] Removing unnecessary variables for CFluidScalar constructor Removing unnecessary variables for CFluidScalar constructor Sep 23, 2024
@Cristopher-Morales Cristopher-Morales merged commit d0e98e1 into develop Sep 23, 2024
35 of 38 checks passed
@Cristopher-Morales Cristopher-Morales deleted the feature_cleaning branch September 23, 2024 17:50
joshkellyjak pushed a commit to joshkellyjak/SU2 that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants