Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further parallel regions #2208

Merged
merged 9 commits into from
Feb 16, 2024
Merged

Add further parallel regions #2208

merged 9 commits into from
Feb 16, 2024

Conversation

jblueh
Copy link
Contributor

@jblueh jblueh commented Feb 13, 2024

Proposed Changes

Add further parallel regions in discrete adjoint computations.

Changes in this PR also reduce the memory footprint of hybrid parallel AD, by avoiding that freed indices end up in tapes not used thereafter, and by aligning the serial and parallel parts between flow and mesh recording.

Related Work

#1214

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@jblueh jblueh changed the title [WIP] Add further parallel regions Add further parallel regions Feb 16, 2024
@jblueh jblueh merged commit d65b4b8 into develop Feb 16, 2024
31 checks passed
@jblueh jblueh deleted the add_parallel_regions branch February 16, 2024 18:09
@jblueh jblueh mentioned this pull request Mar 1, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants