Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix of CoolProp fluid model #1947

Merged
merged 9 commits into from
Mar 8, 2023

Conversation

PENGYAN777
Copy link
Contributor

@PENGYAN777 PENGYAN777 commented Mar 4, 2023

Proposed Changes

Two bugs related to CoolProp fluid model are found and solved:
1.Since there is no solver for two phase flow, then I ask CoolProp to assume the flow is single gas phase if the thermodynamics states are located on the liquid-vapor saturation curve.
2. CoolProp has some issues to update the thermodynamics states if the input pressure is very close critical pressure Pc, see here. So I let pressure equal to 0.99 Pc if pressure is very close to Pc.

Related Work

This work is related to PR #1806.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@PENGYAN777 PENGYAN777 changed the title BUg fix of CoolProp fluid model Bug fix of CoolProp fluid model Mar 4, 2023
@PENGYAN777 PENGYAN777 added the bug label Mar 4, 2023
@WallyMaier WallyMaier changed the base branch from master to develop March 4, 2023 13:16
SU2_CFD/src/fluid/CCoolProp.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/fluid/CCoolProp.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/fluid/CCoolProp.cpp Outdated Show resolved Hide resolved
SU2_CFD/include/fluid/CCoolProp.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/fluid/CCoolProp.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/fluid/CCoolProp.hpp Outdated Show resolved Hide resolved
@PENGYAN777 PENGYAN777 merged commit edaceda into su2code:develop Mar 8, 2023
@PENGYAN777 PENGYAN777 mentioned this pull request May 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants