Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile SU2 with Mutation++ for regression tests #1935

Merged
merged 20 commits into from
Aug 20, 2023
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
config_set: [BaseMPI, ReverseMPI, ForwardMPI, BaseNoMPI, ReverseNoMPI, ForwardNoMPI, BaseOMP, ReverseOMP, ForwardOMP]
include:
- config_set: BaseMPI
flags: '-Denable-pywrapper=true -Denable-coolprop=true -Denable-tests=true --warnlevel=2 --werror'
flags: '-Denable-pywrapper=true -Denable-coolprop=true -Denable-mpp=true -Denable-tests=true --warnlevel=2 --werror'
pcarruscag marked this conversation as resolved.
Show resolved Hide resolved
pcarruscag marked this conversation as resolved.
Show resolved Hide resolved
- config_set: ReverseMPI
flags: '-Denable-autodiff=true -Denable-normal=false -Denable-pywrapper=true -Denable-tests=true --warnlevel=3 --werror'
- config_set: ForwardMPI
Expand Down
5 changes: 2 additions & 3 deletions Common/src/CConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3942,9 +3942,8 @@ void CConfig::SetPostprocessing(SU2_COMPONENT val_software, unsigned short val_i
}
}

if (Kind_FluidModel == MUTATIONPP &&
(Kind_TransCoeffModel != TRANSCOEFFMODEL::WILKE && Kind_TransCoeffModel != TRANSCOEFFMODEL::CHAPMANN_ENSKOG)) {
SU2_MPI::Error("Transport model not available for NEMO solver using MUTATIONPP. Please use the WILKE or CHAPMANN_ENSKOG transport model instead..",
if (Kind_FluidModel == MUTATIONPP && (Kind_TransCoeffModel == TRANSCOEFFMODEL::SUTHERLAND)) {
SU2_MPI::Error("Transport model not available for NEMO solver using MUTATIONPP. Please use the WILKE, GUPTAYOS, or CHAPMANN_ENSKOG transport model instead.",
CURRENT_FUNCTION);
}

Expand Down
12 changes: 10 additions & 2 deletions meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,16 @@ endforeach
catch2_dep = declare_dependency(include_directories: 'externals/catch2/')

if get_option('enable-mpp')
cmake = import('cmake')
mpp_subproj = cmake.subproject('Mutationpp')
if build_machine.cpu_family() == 'x86' or build_machine.cpu_family() == 'x86_64'
cmake = import('cmake')
cmake_opts = cmake.subproject_options()
cmake_opts.set_override_option('warning_level', '0')
cmake_opts.add_cmake_defines({
'CMAKE_MAKE_PROGRAM': meson.source_root() + '/ninja',
'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'
})
endif
mpp_subproj = cmake.subproject('Mutationpp', options: cmake_opts)
mpp_dep = mpp_subproj.dependency('mutation++')
su2_deps += mpp_dep
su2_cpp_args += '-DHAVE_MPP'
Expand Down
2 changes: 1 addition & 1 deletion meson_scripts/init.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def init_submodules(method = 'auto'):
github_repo_meson = 'https://github.com/mesonbuild/meson'
sha_version_ninja = '52649de2c56b63f42bc59513d51286531c595b44'
github_repo_ninja = 'https://github.com/ninja-build/ninja'
sha_version_mpp = '5ff579f43781cae07411e5ab46291c9971536be6'
sha_version_mpp = '4cb6e3a05c15f49ffd346dc9f185ccc3459728b0'
github_repo_mpp = 'https://github.com/mutationpp/Mutationpp'
sha_version_coolprop = '0ce42fcf3bb2c373512bc825a4f0c1973a78f307'
github_repo_coolprop = 'https://github.com/CoolProp/CoolProp'
Expand Down
2 changes: 1 addition & 1 deletion subprojects/Mutationpp
Submodule Mutationpp updated 166 files