Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address NEMO compile warnings #1918

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Address NEMO compile warnings #1918

merged 1 commit into from
Feb 7, 2023

Conversation

WallyMaier
Copy link
Contributor

@WallyMaier WallyMaier commented Feb 7, 2023

Proposed Changes

This address the issue in #1916 to resolve the Intel compiler warnings generated by NEMO.

Turns out I don't have access to an intel compiler, but -warnlevel=3 using GCC does not give any issues. @vdweide, @pcarruscag, @bigfooted could you make sure the issue is resolved?

Related Work

Issue #1916

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).

@vdweide
Copy link
Contributor

vdweide commented Feb 7, 2023

@WallyMaier, I don't get any warnings anymore. Thanks.

@WallyMaier WallyMaier merged commit 3631f60 into develop Feb 7, 2023
@WallyMaier WallyMaier deleted the remove_nemo_warnings branch February 7, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants