-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OptimalPropeller function cleanup #1846
OptimalPropeller function cleanup #1846
Conversation
Welcome to SU2 and thank you for your contribution. Is there something else you want to do in this PR? If not, please have a look at the CodeQL alert and then we can merge. |
Hello, sorry last week I did not had time to continue to work on it. If it is OK for you, I will make a few other changes between today and tomorrow, that could improve the code and then I think we could merge it. |
@pcarruscag could you run the workflow again, I made some small modifications, but now I cannot see the CodeQL alert anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add yourself to AUTHORS.md (in the root of the repo) please
Proposed Changes
I used the OptimalPropeller function for another project a saw a lot of code that could be cleanup in order to be a bit more pythonic and easy to read.
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.