Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment RefElemLength #1831

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Fix comment RefElemLength #1831

merged 2 commits into from
Nov 28, 2022

Conversation

snow54
Copy link
Contributor

@snow54 snow54 commented Nov 27, 2022

Proposed Changes

Give a brief overview of your contribution here in a few sentences.
The comment and the code are inconsistent regarding RefElemLength. Propose to change the comment from 0.1m to 1.0m.

 /*--- Length based parameter for slope limiters uses a default value of
  0.1m ---*/

 RefElemLength = 1.0;

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
Resolve #1830.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@snow54 snow54 merged commit bdc2bcd into develop Nov 28, 2022
@snow54 snow54 deleted the fix_comment_RefElemLength branch November 28, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants