Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multizone with species transport #1821

Merged
merged 21 commits into from
Nov 21, 2022
Merged

Multizone with species transport #1821

merged 21 commits into from
Nov 21, 2022

Conversation

bigfooted
Copy link
Contributor

@bigfooted bigfooted commented Nov 14, 2022

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

Multizone does not work yet for species transport
This is a WIP to discuss the implementation details online. It does not work yet!

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
As mentioned in #1818

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pr-triage pr-triage bot removed the PR: draft label Nov 15, 2022
@bigfooted
Copy link
Contributor Author

@EvertBunschoten Thanks! That seemed to work!
species

@pcarruscag pcarruscag changed the title [WIP] multizone with species transport Multizone with species transport Nov 16, 2022
SU2_CFD/include/solvers/CSpeciesSolver.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/solvers/CSpeciesSolver.hpp Outdated Show resolved Hide resolved
SU2_CFD/src/solvers/CSpeciesSolver.cpp Outdated Show resolved Hide resolved
@bigfooted
Copy link
Contributor Author

bigfooted commented Nov 20, 2022

How well does a restart work in general for multizone? I restart from a converged solution and the result at the zone interface shows high residuals, and I do not recover the exact residual values. The solution looks fine everywhere except at the zone interface. This image below shows the residuals for velocity.
[EDIT: high residuals is relative, it is still 1e-12, but it is higher than what it should be]
screenshot

@pcarruscag
Copy link
Member

What's high in this case? Is it larger than the maximum residuals you have in the rest of the domain?
BTW you need to change the file .github/workflows/regression.yml to point to your testcases branch.

@bigfooted bigfooted merged commit 9f082de into develop Nov 21, 2022
@bigfooted bigfooted deleted the feature_species_multizone branch November 21, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants