-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multizone with species transport #1821
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@EvertBunschoten Thanks! That seemed to work! |
bigfooted
commented
Nov 16, 2022
bigfooted
commented
Nov 16, 2022
pcarruscag
changed the title
[WIP] multizone with species transport
Multizone with species transport
Nov 16, 2022
pcarruscag
reviewed
Nov 16, 2022
Co-authored-by: Pedro Gomes <[email protected]>
…e/SU2 into feature_species_multizone
pcarruscag
reviewed
Nov 18, 2022
bigfooted
commented
Nov 19, 2022
bigfooted
commented
Nov 19, 2022
What's high in this case? Is it larger than the maximum residuals you have in the rest of the domain? |
pcarruscag
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Multizone does not work yet for species transport
This is a WIP to discuss the implementation details online. It does not work yet!
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
As mentioned in #1818
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.