Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LUT routine #1792

Merged
merged 18 commits into from
Oct 19, 2022
Merged

Update LUT routine #1792

merged 18 commits into from
Oct 19, 2022

Conversation

bigfooted
Copy link
Contributor

Proposed Changes

Give a brief overview of your contribution here in a few sentences.
This is a small update of the lookup table routines to prepare for the implementation of the flamelet model. A bug was fixed and the header file definition changed (keywords in sentences are capitalized). Some small textual changes were made.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
related to the upcoming PR for feature_new_flamelet

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted bigfooted marked this pull request as draft October 16, 2022 08:34
@bigfooted bigfooted changed the title [WIP] Feature update lut [WIP] Update LUT routine Oct 16, 2022
@bigfooted
Copy link
Contributor Author

bigfooted commented Oct 16, 2022

@danielmayer I've created a separate PR for the changes that you've made in the existing LUT files. Maybe we can replace these lines with a function:

   if (!line.empty() && (line[line.length()-1] == '\n' || line[line.length()-1] == '\r' )) {
      line.erase(line.length()-1);
    }

[EDIT] I replaced it.

@bigfooted bigfooted changed the title [WIP] Update LUT routine Update LUT routine Oct 18, 2022
@pr-triage pr-triage bot added the PR: draft label Oct 18, 2022
@bigfooted bigfooted marked this pull request as ready for review October 19, 2022 18:16
Common/src/containers/CFileReaderLUT.cpp Outdated Show resolved Hide resolved
Common/src/containers/CFileReaderLUT.cpp Outdated Show resolved Hide resolved
Common/src/containers/CTrapezoidalMap.cpp Outdated Show resolved Hide resolved
Common/src/containers/CFileReaderLUT.cpp Show resolved Hide resolved
Comment on lines 278 to 280
/*! \brief Extracts characters from file_stream, removes trailing control characters,
* and stores them into line.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw it is usually better to put the doxygen comment on the declaration hpp, but it's fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've moved it to the hpp files. When it goes through the regression tests, I'll merge.

@bigfooted bigfooted merged commit e528e80 into develop Oct 19, 2022
@bigfooted bigfooted deleted the feature_update_LUT branch October 19, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants