-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slidingmesh for SA #1344
Fix slidingmesh for SA #1344
Conversation
in CInterpolator::ReconstructBoundary.
I followed @pcarruscag 's request in commit 12974ab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Max, I missed the solution v primitive part of the problem.
I don't think forwarding GetPrimitive to GetSolution by default is a good option, a "Slinding state" layer could be appropriate but that does not need to be fixed right now. |
Co-authored-by: Pedro Gomes <[email protected]>
By "Sliding State layer", do you mean a virtual |
I would add that layer to the solver so that the interpolation does not have to bypass it by going straight to the nodes. |
Ok thanks Pedro! |
Thanks @maxaehle 💐 Not sure how this will interact with scalar solvers (species transport) to come ... but in case someone there wants to work with sliding interfaces then I guess one has to test that a priori |
Proposed Changes
CSlidingInterface::GetDonor_Variable
needs to access thePrimitive
of flow variables and theSolution
of turbulent variables. Which one is the case, is currently decided by checkingdonor_solution->GetnPrimVar() == 2
(true->turbulent, false->flow). If the SA turbulence model is used, the non-overidden "virtual placeholder"CVariable::GetPrimitive(unsigned long,unsigned long) const
returning zero is incorrectly called.We propose to fix this by additionally checking for
donor_solution->GetnPrimVar() == 1
.Related Work
@maxaehle, @mcmorelli, @BeckettZhou, @EduardoMolina
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.