[WIP] Feature turbomachinery restruct singlezone #1316

NAnand-TUD · 2021-06-28T15:45:58Z

Proposed Changes

This branch includes steady state turbomachinery features like multi-zone mixing plane, pressure ramps and rotations ramps essential for convergence. In additions, multi-zone performance computations with screen output is also implemented here.

Related Work

The code now follows the same path as that of fluid driver, CTurbomachineryDriver will be removed after verification. There is some implementation of boost currently, it will be re-coded soon.*

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

[X ] I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

*Please note, this is a draft pull request. I wish to get more comments on the section of code which are working like, mixing plane and performance computations. Config, tutorial and comments will be updated follow soon after.

…boIteration

Conflicts: SU2_CFD/include/solvers/CEulerSolver.hpp SU2_CFD/src/integration_time.cpp SU2_CFD/src/iteration_structure.cpp SU2_CFD/src/meson.build SU2_CFD/src/solvers/CEulerSolver.cpp SU2_CFD/src/solvers/CNSSolver.cpp

…e screen output iterations

…work in progress

…://github.com/su2code/SU2 into feature_turbomachinery_restruct_singlezone

…ery boundary value table added for priting, printing frequency is still hard coded, to be fixed in future

…ing Plane under process. Turbine and Compressor calcualtion if statement added

…e performance is not computer for all blades. This needs to be identified and implemented

…ixed and turbo span calculation to be fixed.

…. Mutizone is still crashing... investigation in progress

…test to follow

…is working. Need to revisit the performance computation next week to fix the calcualtions

pcarruscag

Thank you @salvovitale and @NAnand-TUD this is a tremendous step forward, I cannot wait to delete some legacy parts of SU2.
Just a heads up, you have some changes to codi and meson.

Common/include/option_structure.hpp

pcarruscag · 2021-07-03T13:07:49Z

Common/src/CConfig.cpp

@@ -1499,6 +1499,9 @@ void CConfig::SetConfig_Options() {
  /*!\brief TURBOMACHINERY_KIND \n DESCRIPTION: types of turbomachynery architecture.
      \n OPTIONS: see \link TurboMachinery_Map \endlink \n Default: AXIAL */
  addEnumListOption("TURBOMACHINERY_KIND",nTurboMachineryKind, Kind_TurboMachinery, TurboMachinery_Map);
+  /*!\brief TURBOMACHINERY_KIND \n DESCRIPTION: types of turbomachynery Performance Calculations.
+      \n OPTIONS: see \link TurboPerfKind_Map \endlink \n Default: TURBINE */
+  addEnumListOption("TURBO_PERF_KIND", nTurboMachineryKind, Kind_TurboPerf=0, TurboPerfKind_Map);


What does the =0 do?

pcarruscag · 2021-07-03T13:09:32Z

Common/src/geometry/CPhysicalGeometry.cpp

-              if ((jVertex != -1) && (PeriodicBoundary == (val_iZone + 1))){
-                nSpan++;
+              if ((jVertex != -1) && (PeriodicBoundary == ((val_iZone) + 1)) && nodes->GetDomain(iPoint)) {
+                  nSpan++;


Was my fix of this function incorrect?

There were a lot of differences in this file, so I tried to stick to the algorithm the was working than to have more uncertainty.

I could argue the same, since I went out of my way to debug this problem for this user #1219 when no one else did. So, if it is all the same, put it back.

pcarruscag · 2021-07-03T13:11:42Z

SU2_CFD/include/iteration_structure.hpp

+ * \file iteration_structure.hpp
+ * \brief Headers of the iteration classes used by SU2_CFD.


This and the associated .cpp were split into separate files. You will need to delete and commit.

SU2_CFD/include/objectives/turbomachinery/CTurbomachineryPerformance.hpp

pcarruscag · 2021-07-03T13:33:10Z

SU2_CFD/src/integration/CMultiGridIntegration.cpp

+        solver_container[FinestMesh][FLOW_SOL]->TurboAverageProcess(solver_container[FinestMesh], geometry[FinestMesh],config,INFLOW);
+        solver_container[FinestMesh][FLOW_SOL]->TurboAverageProcess(solver_container[FinestMesh], geometry[FinestMesh], config, OUTFLOW);
+
+        /*--- Gather Inflow and Outflow quantities on the Master Node to compute performance ---*/
+
+        solver_container[FinestMesh][FLOW_SOL]->GatherInOutAverageValues(config, geometry[FinestMesh]);
+
+        /* --- compute turboperformance for each stage and the global machine ---*/
+        //TODO: for multi-zone turbo this should be move to the last zone ---*/
+          solver_container[FinestMesh][FLOW_SOL]->ComputeTurboPerformance(config, geometry[FinestMesh]);
+      }


Could these be wrapped by a single method? Just to reduce the number of virtual methods in CSolver (less virtual boilerplate to maintain)

pcarruscag · 2021-07-03T13:34:17Z

SU2_CFD/src/iteration/CFluidIteration.cpp

+  if (config[ZONE_0]->GetBoolTurbomachinery() && config[val_iZone]->GetSinglezone_Driver()){
+
+    /*--- Turbomachinery Performance Computation ---*/
+    if (val_iZone == config[ZONE_0]->GetnZone()-1)


Why not just ZONE_0 ? You want the last? (but there single zone driver only does one 🤔 )

pcarruscag · 2021-07-03T13:44:38Z

SU2_CFD/src/iteration/CFluidIteration.cpp

+    rampFreq       = SU2_TYPE::Int(config_container[ZONE_0]->GetRampOutletPressure_Coeff(1));
+    finalRamp_Iter = SU2_TYPE::Int(config_container[ZONE_0]->GetRampOutletPressure_Coeff(2));


At some point you may want a more expressive way to do this, for example create a small struct for "ramps" so that you can access things by name (e.g. frequency) we have the same problem with adaptive CFL params.

pcarruscag · 2021-07-03T13:46:56Z

SU2_CFD/src/objectives/turbomachinery/CTurbomachineryPerformance.cpp

+  auto velocity = primitiveState.GetVelocity();
+  Velocity.assign(velocity.begin(), velocity.end());


It is for these types of things that returning const & is more efficient.

pcarruscag · 2021-07-03T13:48:01Z

SU2_CFD/src/objectives/turbomachinery/CTurbomachineryPerformance.cpp

+  auto enthalpyOutIs = FluidModel.GetStaticEnergy() + OutletState.GetPressure() / FluidModel.GetDensity();
+  auto tangVel = primitives.GetOutletPrimitiveState().GetTangVelocity();
+  auto relVelOutIs2 = 2 * (OutletState.GetRothalpy() - enthalpyOutIs) + tangVel * tangVel;


Don't use auto for the return of computations with su2doubles, causes AD problems, use su2double explicitly.

stale · 2022-03-02T09:00:48Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

stale · 2022-06-23T05:15:39Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

salvovitale and others added 30 commits February 8, 2020 23:33

restruct single-zone turbo problem to run without TurboDriver and Tur…

6947268

…boIteration

isolate turboperformance

854295c

Merge branch 'develop' into feature_turbomachinery_restruct_singlezone

305dec9

Conflicts: SU2_CFD/include/solvers/CEulerSolver.hpp SU2_CFD/src/integration_time.cpp SU2_CFD/src/iteration_structure.cpp SU2_CFD/src/meson.build SU2_CFD/src/solvers/CEulerSolver.cpp SU2_CFD/src/solvers/CNSSolver.cpp

change some loops

fd32865

Branch updated with Develop, Turbo-performance parameters added in th…

6ebd4d9

…e screen output iterations

Brnach updated with develop

2bd3dc7

History writing is working... Turbomachinery performance calculation …

a5ec64f

…work in progress

implement some of Pedro comments

0a4c691

fix issue with InletState not available in Output

d929b93

Testing output

7f36374

:q!Merge branch 'feature_turbomachinery_restruct_singlezone' of https…

7a60aef

…://github.com/su2code/SU2 into feature_turbomachinery_restruct_singlezone

History tabled fixed with mass flow convergence vales and turbomachin…

90b1114

…ery boundary value table added for priting, printing frequency is still hard coded, to be fixed in future

Single zone and Multizone implemented... Debugging multizone with Mix…

121dd26

…ing Plane under process. Turbine and Compressor calcualtion if statement added

Mixing Plane is working

7a8d088

Mass flow and performance calculations fixed

b3b9143

Testing Mass Flow rate for 3D problems

0da413c

Mutizone display being fixed now

a4e75cc

Stil exploring the performance calculatings, Currently, seems like th…

92cb7f3

…e performance is not computer for all blades. This needs to be identified and implemented

Mixing Plane call is now fixed, but there is still segmentation fault

45010b9

Mixing-Plane possible is now working.. validation in progress

174a8fb

Performance priting is fixed now

aa6defd

Single zone was crashing... It is fixed now

607678b

Logical error fixed

549a4fa

2D MultiZone Turbomachinery test case is working, performance to be f…

73cf81d

…ixed and turbo span calculation to be fixed.

Span Calculation fixed and multizone mixing plane fixed

b4eb8a5

Commented turbo performance to check a code in HPC

8783fee

Back Pressure and Rotation Ramp implemented, Testing in progress

16b84fd

Multi-Zone grid rotation and backpressure ramp is now working

e6cf5f9

Small error in Mutizone output: Now fixed

2c9f80b

Single zone performance computaion is working with revised approach..…

858b283

…. Mutizone is still crashing... investigation in progress

NAnand-TUD added 9 commits May 7, 2021 08:15

Latest Changes

1601002

small changes

bd0fb25

Small errors

3b2552f

Mutizone again establized, machine performance under process

cda5861

Mutizone again establized, machine performance under process

997cabd

Performance computation per blade is working, for 2D MZ problems, 3D …

1ef9960

…test to follow

MZ performance compuation is working now, also span wise calcualtion …

c25a721

…is working. Need to revisit the performance computation next week to fix the calcualtions

Performance calculations added: Some testing in progress

64cf875

Merged with Develop, some code cleaning in progress

6d29126

NAnand-TUD requested review from talbring and pcarruscag June 28, 2021 15:45

pr-triage bot added the PR: draft label Jun 28, 2021

Fixes in performacne output

1888aa5

pcarruscag reviewed Jul 3, 2021

View reviewed changes

pcarruscag changed the title ~~Feature turbomachinery restruct singlezone~~ [WIP] Feature turbomachinery restruct singlezone Jul 3, 2021

NAnand-TUD added 3 commits July 12, 2021 11:07

Changes made to comply with the comments

b5679b2

Small bug fix and performance improvement

724b77c

Boost capability removed, Adjoint is compiling now

a5a503e

pcarruscag mentioned this pull request Jan 13, 2022

MAJOR ISSUES / DEVELOPMENT AREAS #1487

Open

stale bot added the stale label Mar 2, 2022

added MASS_FLOW_OUTLET BC, fixed turbo performance

c002a72

stale bot removed the stale label Apr 4, 2022

added Enthalpy, Tot Enthalpy and Sound Speed in volume output fields

a151f7d

pcarruscag mentioned this pull request May 9, 2022

Turbomachinery adjoint objectives and Total-Total Eff computation #1628

Closed

stale bot added the stale label Jun 23, 2022

stale bot closed this Jul 10, 2022

joshkellyjak mentioned this pull request Apr 14, 2023

New turbo ouputs #2011

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Feature turbomachinery restruct singlezone #1316

[WIP] Feature turbomachinery restruct singlezone #1316

NAnand-TUD commented Jun 28, 2021

pcarruscag left a comment

pcarruscag Jul 3, 2021

pcarruscag Jul 3, 2021

NAnand-TUD Jul 4, 2021

pcarruscag Jul 4, 2021

pcarruscag Jul 3, 2021

pcarruscag Jul 3, 2021

pcarruscag Jul 3, 2021

pcarruscag Jul 3, 2021

pcarruscag Jul 3, 2021

pcarruscag Jul 3, 2021

stale bot commented Mar 2, 2022

stale bot commented Jun 23, 2022

		* \file iteration_structure.hpp
		* \brief Headers of the iteration classes used by SU2_CFD.

		rampFreq = SU2_TYPE::Int(config_container[ZONE_0]->GetRampOutletPressure_Coeff(1));
		finalRamp_Iter = SU2_TYPE::Int(config_container[ZONE_0]->GetRampOutletPressure_Coeff(2));

		auto velocity = primitiveState.GetVelocity();
		Velocity.assign(velocity.begin(), velocity.end());

[WIP] Feature turbomachinery restruct singlezone #1316

[WIP] Feature turbomachinery restruct singlezone #1316

Conversation

NAnand-TUD commented Jun 28, 2021

Proposed Changes

Related Work

PR Checklist

pcarruscag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Mar 2, 2022

stale bot commented Jun 23, 2022