Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFVMOutput & Streamwise+spanwise periodic #1290

Merged
merged 30 commits into from
Jun 8, 2021

Conversation

TobiKattmann
Copy link
Contributor

@TobiKattmann TobiKattmann commented May 19, 2021

Proposed Changes

Hi all,

  • Little change to make streamwise and spanwise periodic simulations possible (in CIncNSSolver.cpp).
  • Some cleanup in CConjugateHeatInterface
  • Added a CFVMOutput class that only has a CommonFVMoutput for Volume output (COORD-XYZ (fresh addition), MESH_QUALITY, Multigrid visualization and RANK)
  • in the output folder(s) there were quite some wrong doxygen \file <filename>, i changed that. I renamed CAdjFlowOutput.hpp -> CAdjFlowCompOutput.hpp as the cpp as that name and that class as well.
  • little changes/additions to unst CHT gradient validation case

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@TobiKattmann TobiKattmann changed the title Streamwise + spanwise periodic [WIP] Streamwise + spanwise periodic May 19, 2021
@TobiKattmann TobiKattmann marked this pull request as draft May 19, 2021 12:00
@pr-triage pr-triage bot added the PR: draft label May 19, 2021
@TobiKattmann TobiKattmann changed the title [WIP] Streamwise + spanwise periodic CFVMOutput & Streamwise+spanwise periodic Jun 2, 2021
@TobiKattmann TobiKattmann marked this pull request as ready for review June 2, 2021 16:10
@@ -80,7 +80,7 @@
adjoint.addExpected("solution_adj_avtp_1_00053.dat")

# gradient projection
dot = adjont = ExternalRun("DOT",dot_ad_command,True)
dot = ExternalRun("DOT",dot_ad_command,True)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @danielmayer for these changes

@TobiKattmann
Copy link
Contributor Author

The CodeFactor issue is the usual Complex Code in CSolver.hpp so it can be discarded. Otherwise I have not really more to add

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍 few comments below

SU2_CFD/src/drivers/CMultizoneDriver.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/output/CFVMOutput.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/solvers/CIncNSSolver.cpp Outdated Show resolved Hide resolved
SU2_CFD/include/output/CFVMOutput.hpp Outdated Show resolved Hide resolved
SU2_CFD/src/meson.build Show resolved Hide resolved
SU2_CFD/src/drivers/CMultizoneDriver.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/drivers/CMultizoneDriver.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/output/CFVMOutput.cpp Outdated Show resolved Hide resolved
SU2_CFD/include/output/CFVMOutput.hpp Outdated Show resolved Hide resolved
@TobiKattmann
Copy link
Contributor Author

Thanks for the review and fixing the mistakes @pcarruscag

@TobiKattmann TobiKattmann merged commit 919900a into develop Jun 8, 2021
@TobiKattmann TobiKattmann deleted the streamwise_spanwise_periodic branch June 8, 2021 16:52
@pcarruscag
Copy link
Member

No no, thank you for continuing to improve the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants