Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi grid output #1266

Merged
merged 5 commits into from
Apr 28, 2021
Merged

Multi grid output #1266

merged 5 commits into from
Apr 28, 2021

Conversation

pcarruscag
Copy link
Member

Proposed Changes

New output to visualize the coarse grids.
It is based on coloring nodes, which is a little difficult to visualize with Paraview since it interpolates to elements, anyway:
image

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@pcarruscag
Copy link
Member Author

Last week folks mentioned, during the meeting, that this would be helpful, so I'll take it as approved.

@pcarruscag pcarruscag merged commit a007256 into develop Apr 28, 2021
@pcarruscag pcarruscag deleted the visualize_multigrid branch April 28, 2021 09:54
TobiKattmann
TobiKattmann reviewed Apr 28, 2021
View reviewed changes
Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💐 Thanks, also for the little stuff around

Common/src/CConfig.cpp Show resolved Hide resolved
SU2_CFD/src/output/CFlowOutput.cpp
@@ -2735,6 +2735,41 @@ bool CFlowOutput::WriteVolume_Output(CConfig *config, unsigned long Iter, bool f
return false || force_writing;
}

void CFlowOutput::AddCommonFVMOutputs(const CConfig *config) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Special reason to not move COORD-XYZ here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order matters I think.

Copy link
Contributor

@TobiKattmann TobiKattmann Apr 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep it does (tried it out) ... it needs to be the first, at least for paraview output

TobiKattmann added a commit that referenced this pull request Apr 28, 2021
@TobiKattmann
Move COORDs to CommonFVMOutput. Following #1266 by @pcarruscag
e28e7bb
TobiKattmann added a commit that referenced this pull request Apr 28, 2021
@TobiKattmann
Revert "Move COORDs to CommonFVMOutput. Following #1266 by @pcarruscag"
11ae1a9 
This reverts commit e28e7bb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiKattmann TobiKattmann TobiKattmann left review comments

Assignees
No one assigned
Labels
changelog:feature PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcarruscag @TobiKattmann