Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autofix for rule "selector-type-case" #3668

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

EliazTray
Copy link
Member

Which issue, if any, is this issue related to?

e.g. "Closes #3663 "

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

@EliazTray EliazTray closed this Sep 13, 2018
@EliazTray EliazTray reopened this Sep 13, 2018
@EliazTray
Copy link
Member Author

@ota-meshi

in branch master, it asls occurs this when run test. how to solve it?

@ota-meshi
Copy link
Member

I think it is the same problem as here.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request!
I have a change request.

@ota-meshi
Copy link
Member

@EliazTray

in branch master, it asls occurs this when run test. how to solve it?

It was solved!

@ota-meshi
Copy link
Member

@EliazTray Thank you for excellent work!
but, I should have requested one more thing, but I overlooked it. sorry...

Could you add the following sentence to README.md?

The `--fix` option on the [command line](../../../docs/user-guide/cli.md#autofixing-errors) can automatically fix all of the problems reported by this rule.

Please refer to here.

@EliazTray EliazTray force-pushed the autofix/selector-type-case branch from ac6e2f7 to ec5536b Compare September 21, 2018 02:32
@EliazTray
Copy link
Member Author

@ota-meshi
Thanks for your reviewing!
I had added the sentence and rebased the history commits.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EliazTray Thank you for your first-time contribution!

Sorry that it took a little while to get your PR merged. A lot of the team are busy with other things at the moment.

@jeddy3 jeddy3 merged commit 55a004e into stylelint:master Sep 24, 2018
@jeddy3
Copy link
Member

jeddy3 commented Sep 24, 2018

  • Added: selector-type-case autofix (#3668).

@EliazTray EliazTray deleted the autofix/selector-type-case branch September 25, 2018 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add autofix to selector-type-case
3 participants