Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for non-CSS blocks in string-no-newline #3228

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Fix false positives for non-CSS blocks in string-no-newline #3228

merged 1 commit into from
Mar 23, 2018

Conversation

gucong3000
Copy link
Member

@gucong3000 gucong3000 commented Mar 20, 2018 •
edited
Loading

Which issue, if any, is this issue related to?

#3219 #3226

Is there anything in the PR that needs further explanation?

Refactoring the code for rule string-no-newline

@gucong3000 gucong3000 force-pushed the string-no-newline branch 3 times, most recently from ffdb273 to 9739cce Compare March 20, 2018 07:59
@gucong3000 gucong3000 mentioned this pull request Mar 20, 2018
Closed
jeddy3
jeddy3 approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this move away from style-search helps stylelint's compatibility with frameworks like Vue, then this LGTM.

@stylelint/core It'd be great to get a second pair of eyes on this.

@jeddy3 jeddy3 changed the title Fix errors reported from non-CSS blocks for string-no-newline Fix false positives for non-CSS blocks in string-no-newline Mar 20, 2018
@hudochenkov
Copy link
Member

Would you mind running npm run prettier:fix, please? Or rebase your branch on master as it contains a fix for Prettier #3232.

@gucong3000
Copy link
Member Author

If this move away from style-search

Yes.

Would you mind running npm run prettier:fix, please?

Done.

hudochenkov
hudochenkov approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeddy3 jeddy3 merged commit 68e3b7f into master Mar 23, 2018
@jeddy3 jeddy3 deleted the string-no-newline branch March 23, 2018 17:51
@jeddy3
Copy link
Member

jeddy3 commented Mar 23, 2018

  • Fixed: string-no-newline false positives for non-CSS blocks (#3228).

This was referenced Apr 1, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@hudochenkov hudochenkov hudochenkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gucong3000 @hudochenkov @jeddy3