-
-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow leading newlines for source map and copyright comments #2121
Conversation
I've never worked with Jest before but when looking at the build failure, I'm guessing I need to update the snapshots for it? |
The jest snapshots changes look good: Object {
"column": 3,
- "line": 1,
- "rule": "comment-whitespace-inside",
- "severity": "error",
- "text": "Expected whitespace after "/*" (comment-whitespace-inside)",
- }, i.e. we are loosing one /*!
* Bootstrap v4.0.0-alpha.5 (https://getbootstrap.com)
* Copyright 2011-2016 The Bootstrap Authors
* Copyright 2011-2016 Twitter, Inc.
* Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
*/
/*! normalize.css v4.2.0 | MIT License | github.com/necolas/normalize.css */ Where the bootstrap copyright was erroneously triggering a warning (and the normalise one was not) @jwilsson Yep, press |
@jeddy3 Cool, thanks for the explanation! Snapshots are updated. |
Thanks @jwilsson! |
Added note to changelog:
|
…nt#2121) Allow leading newlines for source map and copyright comments
#2120
I opted for a regexp to check for any kind of whitespace so it will accept tabs as well. Let me know if you want tests for tabs too.