Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for #1321 #1412

Closed

Conversation

jkarttunen
Copy link
Contributor

Replaces React.fragment short notation <> with long notation <React.Fragment>

Apparently not all the tooling supports the short notation.

@sapegin
Copy link
Member

sapegin commented Aug 5, 2019

Could you say more about the problem you're trying to fix here? <> is going to be transpiled to React.Fragment anyway, so looks like this won't change anything.

@jkarttunen
Copy link
Contributor Author

Apparently this does cause problems for some people, with certain dependencies. In one of my projects too this prevents me from upgrading to latest styleguidist. No idea what’s the real cause, but this looks like a probable fix. I guess I can verify it by upgrading to fixed package with npm link first. #1321

@jkarttunen
Copy link
Contributor Author

... looking again at the first error message, this might not help at all, it’s the same error message I get, but with long notation.

@stale
Copy link

stale bot commented Nov 4, 2019

😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Consider opening a pull request if you still have this issue or want this feature.

@stale stale bot added the wontfix label Nov 4, 2019
@stale stale bot closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants