Skip to content

Commit

Permalink
Add missing tags to []conditions which got reported by crd checker
Browse files Browse the repository at this point in the history
Adds the task which got reported by the crd checker recently added
as a pre-commit validation.

In a follow up, we should integrate the new ObservedGeneration for
a condition [1]. The observedGeneration represents the
.metadata.generation that the condition was set based upon.

[1] https://github.com/kubernetes/apimachinery/blob/release-1.29/pkg/apis/meta/v1/types.go#L1518

Signed-off-by: Martin Schuppert <[email protected]>
  • Loading branch information
stuggi committed Dec 3, 2024
1 parent 6dc9fd0 commit 8d4a591
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions modules/common/condition/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ type Condition struct {
}

// Conditions provide observations of the operational state of a API resource.
// +patchMergeKey=type
// +patchStrategy=merge
// +listType=map
// +listMapKey=type
type Conditions []Condition

// conditionGroup defines a group of conditions with the same status and severity,
Expand Down

0 comments on commit 8d4a591

Please sign in to comment.