Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address failed PHPUnit test #47

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Address failed PHPUnit test #47

merged 1 commit into from
Nov 25, 2020

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Nov 24, 2020 •
edited
Loading

Changes

Testing instructions

  • Please test with the steps to reproduce in BHH-569

@kienstra
Address failed PHPUnit tests
e7cbdd0 
The WP version in which to not
filter should have been 5.5.
WP 5.5+ has GET and POST methods
for the <ServerSideRender> endpoint.
So this doesn't need to filter that.
It probably wasn't that bad that it filetered it,
probably just needless, not harmful.
@kienstra
Copy link
Contributor Author

Hi @marksabbath,
Could you please review this? Thanks!

@kienstra kienstra requested a review from marksabbath November 24, 2020 04:50
@kienstra kienstra changed the title Address failed PHPUnit tests Address failed PHPUnit test Nov 24, 2020
This was referenced Nov 24, 2020
Merged
Merged
marksabbath
marksabbath approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@marksabbath marksabbath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've successfully tested following those steps @kienstra and it does work properly!

@kienstra
Copy link
Contributor Author

Thanks, @marksabbath! Sounds great.

@kienstra kienstra merged commit 8290ef7 into develop Nov 25, 2020
@kienstra kienstra deleted the fix/phpunit-tests-filter branch November 25, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksabbath marksabbath marksabbath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kienstra @marksabbath