Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.2 is broken #16

Closed
jlachancekffein opened this issue Oct 31, 2019 · 1 comment
Closed

Release 1.0.2 is broken #16

jlachancekffein opened this issue Oct 31, 2019 · 1 comment

Comments

@jlachancekffein
Copy link

Your last release (1.0.2) is broken. It is now impossible to edit all the entries in all our CMS (live website).

image

The problem is this code: src/craftCMS/vendor/studioespresso/craft-seo-fields/src/SeoFields.php (line 268)

Craft::$app->getView()->hook('cp.entries.edit.details', function (array &$context) {
            $handle = $this->getSettings()->fieldHandle;
            if ($context['entryId']) {
                if ($context['entry']->$handle instanceof SeoFieldModel) {
                }
            }
        });

We have to fix it on all our live website inside vendor by commenting this code. How this useless code can be in an official release ?

I have some expectations of a 49$ plugin. Can you please test your release before push it to composer ?

Sorry but I raised one issue a day in the last three days. For a free plugin I can understand but not for a 49$.

Thank you !

janhenckens added a commit that referenced this issue Oct 31, 2019
@janhenckens
Copy link
Member

Hey there. Very sorry about that, just released a fix for this.

There are a couple of free SEO alternatives, you're welcome to switch to those if you wish.
I also see you haven't purchased a license for the plugin yet and I apologize if this error will stop you from doing that.

Let me know if there is anything else I can help you with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants