This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
Fix Py2k method name type #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix introduced in 227231f introduced another bug: By enabling binary strings, Python 2 would serialize the method name as a binary string, not UTF-8 as according to the standard. An obvious way to make this fail is by running the server with Python 3 and the client with Python 2. This conditionally converts strings to UTF-8 when using Python 2. Signed-off-by: Martin Braun <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix introduced in 227231f introduced another bug: By enabling
binary strings, Python 2 would serialize the method name as a binary
string, not UTF-8 as according to the standard.
An obvious way to make this fail is by running the server with Python 3
and the client with Python 2.
This conditionally converts strings to UTF-8 when using Python 2.
Signed-off-by: Martin Braun [email protected]