-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is error reporting broken? #25
Comments
I tried to manage error handling directly in the package, but https://github.com/webonyx/graphql-php seems to handle it own. I need to read the code/documentation to manage that. |
cmizzi
pushed a commit
that referenced
this issue
Sep 24, 2018
cmizzi
pushed a commit
that referenced
this issue
Sep 24, 2018
cmizzi
pushed a commit
that referenced
this issue
Sep 24, 2018
Sorry for the delay. Now, we got a real exception handler. It simply manage exception as real exception (thrown from GraphQL) and debug informations if the debug mode is on. |
drasill
pushed a commit
that referenced
this issue
Nov 29, 2018
Same reasoning as graphql/express-graphql#116 (comment) Hope it doesn't break #25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When some of my code throws an
\Error
or\Exception
, the error I get back includes a "location", but no indication of where the error occurred — no file, or class name, or trace.Is this by design? Could we do something like this in
formatError()
?That would give us a nicely formatted trace back to where the original
\Throwable
was thrown, so the error is findable (though it should probably be switched based onenv(APP_DEBUG)
)The text was updated successfully, but these errors were encountered: