-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gowebdav library should not hush up errors #28
Comments
@chripo, what do you think about? |
the lower case methods are not going to be exported. |
I have experience of using Mkdir /path/to/my/file.txt 400 When I fix error suppressing and got this error: x509: certificate signed by unknown authority I understand where the problem is and fix it quickly. That is why I propose to return error messages even from lower case methods. |
Indeed.
Maybe we should wrap error and status code for all exported methods.
|
* bubble up request errors [#28] * inhibit stream close on request * add `StatusError` * `PUT`: check if given target is a directory * Revert "inhibit stream close on request" Cherry-picked into branch dev-bodyclosing. This reverts commit 2889239. Co-authored-by: Christoph Polcin <[email protected]>
If we carefully see on following methods:
client.mkcol()
,client.Mkdir()
,client.MkdirAll()
client.copymove()
,client.doCopyMove()
client.Write()
andclient.WriteStream()
error
s and returns only status code in the best case.I propose to change this behaviour to allow user of our library to get original error message.
The text was updated successfully, but these errors were encountered: