StudentQuiz: All questions disappear when the number of inputted ques… #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions #836555 is equal to or greater than the total available questions
|
Thanks @danghieu1407 for working on this issue. It looks all perfect and merged upstream. One suggestion that the commit message could be made better :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions #836555
is equal to or greater than the total available questions
The pagination logic in the load_questions function was incorrect, so I’ve updated it to use the load_page_questions function, which should resolve the pagination issue. Additionally, I made updates to the moodle-plugin-cli.yml file due to three branch issues (specifically 405 and 404 errors). I’ve also updated the Behat tests accordingly.