Defect 828690: Behat: mod/studentquiz (tt) - Test delete comment feat… #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure. and Test report comment feature. #828690
|
Thanks so much @BruceGoodGuy. This looks good and is merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @AnupamaSarjoshi,
CC @timhunt,
I have completed the development for this ticket. The Behat failure was caused by an issue where, (maybe) due to network instability, the Tiny editor wasn't fully loaded when we tried to set the event listener, resulting in the event not being properly attached. To fix this, I’ve updated the initBindEditor method to ensure that the Tiny editor is fully loaded before proceeding with further actions.
Additionally, I’ve disabled the "Add reply" button initially, as the reply content is always empty at the start, to keep it consistent with the behavior of the "Add comment" button.
Please note, the JavaScript code in this file isn't written in a modern style, so I have not converted it to ES6. I believe this can be resolved in a separate ticket later on.
Could you please review the changes?
Thanks.