avoid null object possiblity

studentquiz · Aug 29, 2019 · 9959f08 · 9959f08
1 parent 0f1557e
commit 9959f08
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/classes/question/bank/question_bank_filter.php b/classes/question/bank/question_bank_filter.php
@@ -157,14 +157,13 @@ public function setupForm(&$mform) {
         if (!empty($group) && !($group instanceof HTML_QuickForm_Error)) {
             $groupelements = $group->getElements();
             if (!empty($groupelements)) {
-                $dateelement = null;
+                $dateselector = array();
                 foreach ($groupelements as $el) {
                     if ($el instanceof MoodleQuickForm_date_selector) {
-                        $dateelement = $el;
+                        $dateselector = $el->getElements();
                         break;
                     }
                 }
-                $dateselector = $dateelement->getElements();
                 if (!empty($dateselector)) {
                     $isbefore = optional_param('timecreated_sdt', 0, PARAM_INT);
                     if ($isbefore && $isbefore['enabled']) {