feature: Add SAM Globals parsing #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2020 13:39
Allows fallbacks to the CodeUri and Handler properties for functions
studds
requested changes
Jul 2, 2020
added 2 commits
July 3, 2020 12:48
Holding the types in a separate module should allow for easier removal when the upstream types incorporate `Globals` from the SAM template
Utilise the new types lib for using the `Globals` property
|
I've tested this out at seems fine, v0.7.0 published to npm now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to use Globals properties within the functions.
My use case was a fallback to the CodeUri property specified in the Globals section of the SAM template.
Unfortunately, the upstream Cloudform repo doesn't yet support SAM templates fully, hence the
@ts-ignorebut there's an open ticket to support SAM. This PR shouldn't interfere with that change if it's comes.