Don't copy source

stu-elastic · Jul 13, 2022 · a08afb8 · a08afb8
1 parent dc1fc58
commit a08afb8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/server/src/main/java/org/elasticsearch/ingest/IngestCtxMap.java b/server/src/main/java/org/elasticsearch/ingest/IngestCtxMap.java
@@ -13,7 +13,6 @@
 import org.elasticsearch.script.Metadata;
 
 import java.time.ZonedDateTime;
-import java.util.HashMap;
 import java.util.Map;
 
 /**
@@ -32,7 +31,9 @@
 class IngestCtxMap extends CtxMap {
 
     /**
-     * Create an IngestCtxMap with the given metadata, source and default validators
+     * Create an IngestCtxMap with the given metadata, source and default validators.
+     *
+     * Source is not copied, callers can observe changes to source.
      */
     IngestCtxMap(
         String index,
@@ -43,7 +44,7 @@ class IngestCtxMap extends CtxMap {
         ZonedDateTime timestamp,
         Map<String, Object> source
     ) {
-        super(new HashMap<>(source), new IngestDocMetadata(index, id, version, routing, versionType, timestamp));
+        super(source, new IngestDocMetadata(index, id, version, routing, versionType, timestamp));
     }
 
     /**