Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue for Buildalyzer couldn't fin sourcefiles #2683

Closed
wants to merge 3 commits into from

Conversation

tnoiretisa
Copy link

For specific solution, when csproj is not "standalone" buildable without solution file, we need to get to Buildalyzers the solution file path

For specific project, we need to pass the solution path to buildalyzer to avoid warn message " Buildalyzer could not find sourcefiles. This should not happen. Will fallback to filesystem scan. Please report an issue at github."
…ld-not-find-sourcefiles

Get Solution file path to Buildalyzer on ProjectAnalyze
@dupdob
Copy link
Member

dupdob commented Sep 27, 2023

hi
I am not sure I understand what problem this PR is supposed to fix. Is there a related issue ? If not, could you please create one, so we can better track the problem

@tnoiretisa
Copy link
Author

hi I am not sure I understand what problem this PR is supposed to fix. Is there a related issue ? If not, could you please create one, so we can better track the problem

Hi, i'm try to add more details on this new issue #2685

@JackSteel97
Copy link
Contributor

@tnoiretisa Could this also be the fix for #931?

@tnoiretisa
Copy link
Author

@tnoiretisa Could this also be the fix for #931?

Logs on #931 don't throw warn on buildalyzer, so i don't know if bugs have the same origin :/

@rouke-broersma
Copy link
Member

@tnoiretisa could you test #2690?

It's more or less your change but refactored to always use the solution file when it's available

@tnoiretisa
Copy link
Author

@rouke-broersma it's works 🙂

@rouke-broersma
Copy link
Member

@rouke-broersma it's works 🙂

thanks for confirming and thanks for finding this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants