fix: Improve build, restore and test (#2845)

* chore: log stryker version * feat: align project analysis between project and solution modes + imp. logging of analysis results * chore: drop use of obsolete VsTest async APIs * chore: update FullFrameworkApp dependencies * fix: force restore packages if msbuild fails * fix: add support for packages.config * fix: tests * fix: force running tests in isolation * revert useless dependency updates * fix: add some log and adjust vstest settings * chore: add tests * fix: fix first projet in solution always tested against all test projects --------- Co-authored-by: Rouke Broersma <[email protected]>
stryker-mutator · Mar 1, 2024 · a14b64b · a14b64b
1 parent 493235f
commit a14b64b
Show file tree

Hide file tree

Showing 21 changed files with 462 additions and 212 deletions.
diff --git a/src/Stryker.CLI/Stryker.CLI/StrykerCLI.cs b/src/Stryker.CLI/Stryker.CLI/StrykerCLI.cs
@@ -148,12 +148,12 @@ _____ _              _               _   _ ______ _______
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Major Bug", "S3168:\"async\" methods should not return \"void\"", Justification = "This method is fire and forget. Task.Run also doesn't work in unit tests")]
         private async void PrintStrykerVersionInformationAsync()
         {
+            var logger = ApplicationLogging.LoggerFactory.CreateLogger<StrykerCli>();
             var assembly = Assembly.GetExecutingAssembly();
             var version = assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion;
 
             if (!SemanticVersion.TryParse(version, out var currentVersion))
             {
-                var logger = ApplicationLogging.LoggerFactory.CreateLogger<StrykerCli>();
                 if (string.IsNullOrEmpty(version))
                 {
                     logger.LogWarning("{Attribute} is missing in {Assembly} at {AssemblyLocation}", nameof(AssemblyInformationalVersionAttribute), assembly, assembly.Location);
@@ -166,6 +166,7 @@ private async void PrintStrykerVersionInformationAsync()
             }
 
             _console.MarkupLine($"Version: [Green]{currentVersion}[/]");
+            logger.LogDebug("Stryker starting, version: {Version}", currentVersion);
             _console.WriteLine();
 
             var latestVersion = await _nugetClient.GetLatestVersionAsync();

diff --git a/src/Stryker.Core/Stryker.Core.UnitTest/Initialisation/InitialBuildProcessTests.cs b/src/Stryker.Core/Stryker.Core.UnitTest/Initialisation/InitialBuildProcessTests.cs
@@ -63,7 +63,7 @@ public void InitialBuildProcess_WithPathAsBuildCommand_TriesWithMsBuildIfDotnetF
                                   @"C:\Program Files\Microsoft Visual Studio\2022\Professional\MSBuild\Current\Bin\MSBuild.exe" + "\" \"" + _cProjectsExampleCsproj + "\"\"");
 
             processMock.Verify(x =>x.Start(It.IsAny<string>(), It.Is<string>(app => app.Contains("dotnet")), It.IsAny<string>(), It.IsAny<IEnumerable<KeyValuePair<string, string>>>(), 0), Times.Once());
-            processMock.Verify(x =>x.Start(It.IsAny<string>(), It.Is<string>(app => app.Contains("MSBuild.exe")), It.IsAny<string>(), It.IsAny<IEnumerable<KeyValuePair<string, string>>>(), 0), Times.Once());
+            processMock.Verify(x =>x.Start(It.IsAny<string>(), It.Is<string>(app => app.Contains("MSBuild.exe")), It.IsAny<string>(), It.IsAny<IEnumerable<KeyValuePair<string, string>>>(), 0), Times.Exactly(3));
         }
 
         [Fact]

diff --git a/src/Stryker.Core/Stryker.Core.UnitTest/Initialisation/NugetRestoreProcessTests.cs b/src/Stryker.Core/Stryker.Core.UnitTest/Initialisation/NugetRestoreProcessTests.cs
diff --git a/src/Stryker.Core/Stryker.Core.UnitTest/Initialisation/ProjectOrchestratorTests.cs b/src/Stryker.Core/Stryker.Core.UnitTest/Initialisation/ProjectOrchestratorTests.cs
@@ -70,7 +70,7 @@ public void ShouldInitializeEachProjectInSolution()
         public void ShouldPassWhenProjectNameIsGiven()
         {
             // arrange
-            // when a solutionPath is given and it's inside the current directory (basePath)
+            // when a solutionPath is given, and it's inside the current directory (basePath)
             var csprojPathName = _fileSystem.Path.Combine(_projectPath, "sourceproject.csproj");
             var testCsprojPathName = _fileSystem.Path.Combine(_projectPath, "test", "testproject.csproj");
             var options = new StrykerOptions
@@ -90,6 +90,31 @@ public void ShouldPassWhenProjectNameIsGiven()
             result.ShouldHaveSingleItem();
         }
 
+        [Fact]
+        public void ShouldRestoreWhenAnalysisFails()
+        {
+            // arrange
+            // when a solutionPath is given, and it's inside the current directory (basePath)
+            var csprojPathName = _fileSystem.Path.Combine(_projectPath, "sourceproject.csproj");
+            var testCsprojPathName = _fileSystem.Path.Combine(_projectPath, "test", "testproject.csproj");
+            var options = new StrykerOptions
+            {
+                ProjectPath = _fileSystem.Path.GetFullPath(testCsprojPathName),
+                SourceProjectName = csprojPathName,
+                SolutionPath = _fileSystem.Path.Combine(_projectPath, "MySolution.sln")
+            };
+
+            var csPathName = _fileSystem.Path.Combine(_projectPath, "someFile.cs");
+            var target = BuildProjectOrchestratorForSimpleProject(SourceProjectAnalyzerMock(csprojPathName, new[] { csPathName }).Object, 
+                TestProjectAnalyzerMock(testCsprojPathName, csprojPathName,  "net4.5", false).Object, out var mockRunner);
+
+            // act
+            var result = target.MutateProjects(options, _reporterMock.Object, mockRunner.Object).ToList();
+
+            // assert
+            result.ShouldHaveSingleItem();
+        }
+
         [Fact]
         public void ShouldFailIfNoProjectFound()
         {
@@ -330,7 +355,7 @@ private ProjectOrchestrator BuildProjectOrchestrator(Dictionary<string, IProject
 
             var target = new ProjectOrchestrator(_projectMutatorMock.Object,
                 initialBuildProcessMock.Object,
-                new InputFileResolver(_fileSystem, new ProjectFileReader(null, _buildalyzerProviderMock.Object)));
+                new InputFileResolver(_fileSystem, new ProjectFileReader(new Mock<INugetRestoreProcess>().Object, _buildalyzerProviderMock.Object)));
 
             var buildalyzerAnalyzerManagerMock = new Mock<IAnalyzerManager>(MockBehavior.Strict);
             buildalyzerAnalyzerManagerMock.Setup(x => x.Projects)
@@ -361,7 +386,7 @@ private ProjectOrchestrator BuildProjectOrchestrator(Dictionary<string, IProject
         /// </summary>
         /// <param name="csprojPathName">project pathname</param>
         /// <param name="sourceFiles">project source files</param>
-        /// <param name="projectReferences">project cross references</param>
+        /// <param name="projectReferences">project references</param>
         private Mock<IProjectAnalyzer> SourceProjectAnalyzerMock(string csprojPathName, string[] sourceFiles, IEnumerable<string> projectReferences = null)
         {
             var properties = new Dictionary<string, string>
@@ -376,13 +401,15 @@ private Mock<IProjectAnalyzer> SourceProjectAnalyzerMock(string csprojPathName,
         /// </summary>
         /// <param name="testCsprojPathName">test project pathname</param>
         /// <param name="csprojPathName">production code project pathname</param>
+        /// <param name="framework"></param>
+        /// <param name="success"></param>
         /// <returns>a mock project analyzer</returns>
         /// <remarks>the test project references the production code project and contains no source file</remarks>
-        private Mock<IProjectAnalyzer> TestProjectAnalyzerMock(string testCsprojPathName, string csprojPathName)
+        private Mock<IProjectAnalyzer> TestProjectAnalyzerMock(string testCsprojPathName, string csprojPathName, string framework = "net6.0", bool success = true)
         {
             var properties = new Dictionary<string, string>{ { "IsTestProject", "True" }, { "Language", "C#" } };
 
-            return BuildProjectAnalyzerMock(testCsprojPathName, Array.Empty<string>(), properties, new List<string> { csprojPathName });
+            return BuildProjectAnalyzerMock(testCsprojPathName, Array.Empty<string>(), properties, new List<string> { csprojPathName }, framework, success);
         }
 
         /// <summary>
@@ -391,13 +418,17 @@ private Mock<IProjectAnalyzer> TestProjectAnalyzerMock(string testCsprojPathName
         /// <param name="csprojPathName">project file name</param>
         /// <param name="sourceFiles">source files to return</param>
         /// <param name="properties">project properties</param>
-        /// <param name="projectReferences">project cross references</param>
+        /// <param name="projectReferences">project references</param>
+        /// <param name="success">analysis success</param>
         /// <returns>a mock project analyzer</returns>
         /// <remarks>
         /// 1. project and source files will be created (empty) in the file system
         /// 2. the project analyzer mock returns a single project result</remarks>
-
-        private Mock<IProjectAnalyzer> BuildProjectAnalyzerMock(string csprojPathName, string[] sourceFiles, Dictionary<string, string> properties, IEnumerable<string> projectReferences)
+        private Mock<IProjectAnalyzer> BuildProjectAnalyzerMock(string csprojPathName,
+            string[] sourceFiles, Dictionary<string, string> properties,
+            IEnumerable<string> projectReferences,
+            string framework = "net6.0",    
+            bool success = true)
         {
             var sourceProjectAnalyzerMock = new Mock<IProjectAnalyzer>(MockBehavior.Strict);
             var sourceProjectAnalyzerResultsMock = new Mock<IAnalyzerResults>(MockBehavior.Strict);
@@ -428,8 +459,8 @@ private Mock<IProjectAnalyzer> BuildProjectAnalyzerMock(string csprojPathName, s
 
             sourceProjectAnalyzerResultMock.Setup(x => x.Properties).Returns(properties);
             sourceProjectAnalyzerResultMock.Setup(x => x.ProjectFilePath).Returns(csprojPathName);
-            sourceProjectAnalyzerResultMock.Setup(x => x.TargetFramework).Returns("net6.0");
-            sourceProjectAnalyzerResultMock.Setup(x => x.Succeeded).Returns(true);
+            sourceProjectAnalyzerResultMock.Setup(x => x.TargetFramework).Returns(framework);
+            sourceProjectAnalyzerResultMock.Setup(x => x.Succeeded).Returns(success);
 
             IEnumerable<IAnalyzerResult> analyzerResults = new[] { sourceProjectAnalyzerResultMock.Object };
             sourceProjectAnalyzerResultsMock.Setup(x => x.Results).Returns(analyzerResults);

diff --git a/src/Stryker.Core/Stryker.Core.UnitTest/TestRunners/CoverageCollectorTests.cs b/src/Stryker.Core/Stryker.Core.UnitTest/TestRunners/CoverageCollectorTests.cs
@@ -80,7 +80,6 @@ public void SelectMutantEarlyIfSingle()
             var collector = new CoverageCollector();
 
             var testCase = new TestCase("theTest", new Uri("xunit://"), "source.cs");
-            var nonCoveringTestCase = new TestCase("theOtherTest", new Uri("xunit://"), "source.cs");
             var mutantMap = new List<(int, IEnumerable<Guid>)> {(5, new List<Guid>{testCase.Id})};
 
             var start = new TestSessionStartArgs