Replace CodePipeline Source trigger from GitHub to ECR #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that ECR as Source is not yet supported at 100% 👎 hashicorp/terraform-provider-aws#7012 I'm trying to make a workaround of this 🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the CodePipeline is triggered. Before it was triggered by a new change pushed into a GitHub repo, which was not ideal since the module was strictly coupled to GitHub and also it was needed to specify a GitHub integration token with the first
terraform apply(as described in the Basic example)Now the trigger for new updates comes from the ECR when a new Docker image is published, so now this modules only cares about updates Docker images and users can delegate other CI/CD processes with a different service like Travis or CircleCI.