Add a contact add/remove button in chat #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -214,6 +215,9 @@ define(['jquery', 'underscore', 'text!partials/chat.html', 'text!partials/chatro | |||
| subscope.p2pstate = false; | |||
| subscope.active = false; | |||
| subscope.pending = 0; | |||
| subscope.isuser = !!(buddy && buddy.session && buddy.session.Userid); | |||
There was a problem hiding this comment.
Changed to isUser.
theurere
force-pushed
the
chat-add-contact
branch
from
768e08d
to
ede149c
Compare
|
Can you please rebase this on develop. |
theurere
force-pushed
the
chat-add-contact
branch
from
ede149c
to
eb6fff5
Compare
|
Rebased on develop. |
| subscope.isContact = event.type === "contactadded"; | ||
| }; | ||
| contacts.e.on("contactadded", subscope.updateContactStatus); | ||
| contacts.e.on("contactremoved", subscope.updateContactStatus); |
There was a problem hiding this comment.
This does not make sense and needs fixing. This events trigger for all contacts and need to be limited/matched to the user in this subscope what so ever. In general i would like it if this two events could be avoided alltogether.
There was a problem hiding this comment.
Am filtering now by userid to correctly handle this. Not sure what else I would use to handle this, other then the contacts api.
theurere
force-pushed
the
chat-add-contact
branch
from
eb6fff5
to
059416a
Compare
| @@ -216,6 +217,9 @@ define(['jquery', 'underscore', 'text!partials/chat.html', 'text!partials/chatro | |||
| subscope.p2pstate = false; | |||
| subscope.active = false; | |||
| subscope.pending = 0; | |||
| subscope.isUser = !!(buddy && buddy.session && buddy.session.Userid); | |||
There was a problem hiding this comment.
I want a type of boolean.
…ontact is added or removed.
… button when the person cannot be added as a contact.
theurere
force-pushed
the
chat-add-contact
branch
from
059416a
to
1303213
Compare
|
I updated this to handle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For single chat sessions and those that are 'users' add a contact add/remove star to the chat menu next to call, upload file, and geolocation.