-
Notifications
You must be signed in to change notification settings - Fork 46
feat: Reuse typescript program in between parses #40
feat: Reuse typescript program in between parses #40
Conversation
@strothj please review |
Awesome. I'll have some time to review this in more detail later today (Sunday). I think one of the original concerns I had when working on this issue was about potential issues that could occur when using a multi-threaded build (https://github.com/TypeStrong/ts-loader#parallelising-builds). I'm not sure that's a valid concern anyways since the |
@strothj hey! :) how is it going? :) can we merge it? |
Thanks for the pull request! I've published this as version |
|
@strothj can this change be reflected in the underyling |
Because we are not reusing the same Typescript instance while parsing ts files there are this issue styleguidist/react-docgen-typescript#112 and this issue #37.
So here I've created a code, which reuse the same program in between parses in the same way as in
ts-loader
it's done (https://github.com/TypeStrong/ts-loader/blob/master/src/servicesHost.ts)