Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change int_nums to int in test_snprintf #248

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Change int_nums to int in test_snprintf #248

merged 2 commits into from
Oct 24, 2024

Conversation

ArtSin
Copy link
Contributor

@ArtSin ArtSin commented Oct 23, 2024

All format specifiers in int_fmt are for int, not long, and all numbers in int_nums fit into int.

@ArtSin
Change int_nums to int in test_snprintf
62953e9 
All format specifiers in `int_fmt` are for `int`, not `long`, and all numbers
in `int_nums` fit into `int`.
sjaeckel
sjaeckel reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a separate testcase for (unsigned) long instead?

Currently that's also pretty random values. I'd love to see how the internal implementation behaves on _MIN/_MAX values ;)

@ArtSin ArtSin requested a review from sjaeckel October 23, 2024 16:17
sjaeckel
sjaeckel approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@sjaeckel sjaeckel merged commit 5690c4e into strophe:master Oct 24, 2024
39 checks passed
@ArtSin ArtSin deleted the fix-test_snprintf-int_nums branch October 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjaeckel sjaeckel sjaeckel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArtSin @sjaeckel