Low hanging fruit #188
Merged
Low hanging fruit #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasis
approved these changes
Dec 2, 2021
sjaeckel
force-pushed
the
low-hanging-fruit
branch
from
0c30161
to
f8efd7d
Compare
sjaeckel
force-pushed
the
low-hanging-fruit
branch
from
f8efd7d
to
b0631e3
Compare
|
Whatever I did on this PR, it somehow lost the diff of the 4 commits ... |
That's really curious! I'm interested what happened here 🤔 |
|
I think I remember what went wrong ... I merged locally, then couldn't push because @pasis added another commit on remote/master. So I rebased master on top of remote/master and pushed this one. (I guess that's where it went wrong) Then I realized that I didn't update this branch, so I reset the branch head to the same commit as master and force-pushed this branch. But because the commits were already on master there was no diff anymore ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some house-keeping and minor features I stumbled over while looking through the code.