forked from moodlehq/moodle-plugin-ci
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adapt the results to the new moodle.Commenting.Package sniff
That Sniff is reporting as correct <empty> components when components cannot be detected. That's the case when you run moodle-cs out from a moodle structure and do not pass a list of valid components (like cibot does). That's exactly the case for the moodle-plugin-ci validation tests, where no moodle complete checkout is available. So, until we stop the sniff to suggest <empty> components (there are other Sniffs, like the PHPUnit.TestCaseNames, for example, that also need the component, but, if empty, it's not checked) we need the hacks applied in this commit to keep things passing.
- Loading branch information
Showing
2 changed files
with
20 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters