Skip to content

Commit

Permalink
Merge pull request moodlehq#255 from stronk7/fix_travis_libonig_problem
Browse files Browse the repository at this point in the history
Add the libonig5 to the Travis packages to install
  • Loading branch information
paulholden authored Nov 7, 2023
2 parents 10674c0 + 2690611 commit d313896
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions .travis.dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ addons:
packages:
- postgresql-13
- postgresql-client-13
- libonig5

services:
- mysql
Expand Down
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ addons:
packages:
- postgresql-13
- postgresql-client-13
- libonig5

services:
- mysql
Expand Down
7 changes: 7 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ The format of this change log follows the advice given at [Keep a CHANGELOG](htt
## [Unreleased]
### Changed
- ACTION SUGGESTED: If you are using GitHub Actions, it's recomended to use `!cancelled()` instead of `always()` for moodle-plugin-ci tests. Adding a final step that always returns failure when the workflow is cancelled will ensure that cancelled workflows are not marked as successful. For a working example, please reference the updated `gha.dist.yml` file.
- ACTION SUGGESTED: For some (unknown) reason, Travis environments with PHP 8.2 have started to fail with error:

```
php: error while loading shared libraries: libonig.so.5
```

To avoid that problem it's recommended to to add the `libonig5` package to the `travis.yml` file. For a working example, please reference the updated `.travis.dist.yml`file.

## [4.1.8] - 2023-10-20
### Changed
Expand Down
1 change: 1 addition & 0 deletions docs/TravisFileExplained.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ addons:
packages:
- postgresql-13
- postgresql-client-13
- libonig5

# Ensure DB and docker services are running.
services:
Expand Down

0 comments on commit d313896

Please sign in to comment.