Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove request-browser #193

Merged
merged 1 commit into from
Apr 2, 2015
Merged

Remove request-browser #193

merged 1 commit into from
Apr 2, 2015

Conversation

ritch
Copy link
Member

@ritch ritch commented Apr 2, 2015

Just use request in the browser...

Close #192

@bajtos

@ritch ritch added the #review label Apr 2, 2015
@bajtos
Copy link
Member

bajtos commented Apr 2, 2015

:shipit:

ritch added a commit that referenced this pull request Apr 2, 2015
@ritch ritch merged commit 97bedcb into master Apr 2, 2015
@ritch ritch removed the #review label Apr 2, 2015
@ritch ritch deleted the fix/req-in-browser branch April 2, 2015 17:55
@bajtos
Copy link
Member

bajtos commented Jun 2, 2015

FWIW, I think this introduced a backwards-incompatibility because request doesn't support hostname-less URLs - see strongloop/loopback-example-offline-sync#69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use request instead of browser-request
2 participants