Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support middleware injected by OpenTelemetry Express Instrumentation plugin #4351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-legrand
Copy link

OpenTelemetry Express Instrumentation injects a proxy object into the router stack, which it
uses for its tracing. This is similar to how NewRelic adds a sentinel handler to the router stack. This commit adds a similar workaround so that loopback can find the original layer.

I made the variable more generic to just test if shimmer is used to wrap the handler, as this library can be used by other libraries.

See also #4119

Checklist

  • New tests added or existing tests modified to cover all changes
    • Unit tests have been added
  • Code conforms with the style guide
    • All lint tests passes

OpenTelemetry injects a proxy object into the router stack, which it
uses for its tracing.  This is similar to how NewRelic
adds a sentinel handler to the router stack. This commit adds a
similar workaround so that loopback can find the original layer.

Made it more generic to just test if shimmer is used to wrap the handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant