-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clearHandlerCache when remote method added or disabled #4011
clearHandlerCache when remote method added or disabled #4011
Conversation
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
7aa7191
to
14f00f8
Compare
@slnode ok to test |
@MohammedEssehemy thank you for the pull request. The change looks good, could you please add tests to verify the fix and prevent regressions in the future? See the following two commits for inspiration: b466bb9, b466bb9 |
@bajtos I found that these test were changed in this commit f43273e and this is the available form now in master. so should this be tested in app.test.js such as rest rebuild after add model test I think it's more relevant to be in rest.middleware.test.js, so I can refactor rest rebuild after add model test to be in rest.middleware.test.js to have the following 4 tests in sequence @bajtos what do you think? |
Either way is fine with me.
Sounds great 👍 Thank you! |
Okay, I'll implement this tonight. |
@bajtos Done. |
@bajtos any updates? |
@bajtos still waiting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay 🙈
The changes look great now!
8806d43
to
e33d10f
Compare
I squashed your two commits into a single one, let's wait for CI results before landing. |
Landed 🎉 Thank you for your first contribution! ❤️ |
Description
fixes issue that Handler Cache won't change when remote method is added or disabled.
Checklist