Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMVER-MAJOR] Make juggler a regular dependency #1943

Merged
merged 1 commit into from
Jan 6, 2016
+16 −4
Merged

[SEMVER-MAJOR] Make juggler a regular dependency #1943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions 3.0-RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,18 @@ All breaking changes must be described here. When adding a new entry,
always describe the impact on users and instructions for upgrading
applications from 2.x to 3.0.

## loopback-datasource-juggler was moved from peerDependencies to dependencies

Originally, we (ab)used peer dependencies to ensure there is only one instance
of loopback-datasource-juggler in the dependency tree, so that there is only
one singleton instance of model registry. This was very fragile and might not
have worked in certain edge cases.

We have reworked loopback-datasource-juggler and connectors to not rely on
a single juggler instance anymore. As the last step, juggler became a regular
dependency.

https://github.com/strongloop/loopback/issues/275

When upgrading application from previous loopback versions, simply remove
loopback-datasource-juggler from your dependencies.
5 changes: 1 addition & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"express": "^4.12.2",
"inflection": "^1.6.0",
"loopback-connector-remote": "^1.0.3",
"loopback-datasource-juggler": "^3.0.0-alpha.1",
"loopback-phase": "^1.2.0",
"nodemailer": "^1.3.1",
"nodemailer-stub-transport": "^0.1.5",
Expand All @@ -57,9 +58,6 @@
"uid2": "0.0.3",
"underscore.string": "^3.0.3"
},
"peerDependencies": {
"loopback-datasource-juggler": "^3.0.0-alpha.1"
},
"devDependencies": {
"bluebird": "^2.9.9",
"browserify": "^10.0.0",
Expand All @@ -84,7 +82,6 @@
"karma-phantomjs-launcher": "^0.1.4",
"karma-script-launcher": "^0.1.0",
"loopback-boot": "^2.7.0",
"loopback-datasource-juggler": "^3.0.0-alpha.1",
"mocha": "^2.1.0",
"sinon": "^1.13.0",
"strong-task-emitter": "^0.0.6",
Expand Down