Add npm audit to empty-server posttest #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
@slnode test please |
dhmlau
approved these changes
May 9, 2019
There was a problem hiding this comment.
@harryadel, thanks for your PR. I've rebased the PR for you.
I think it makes sense to add npm audit especially we had nsp check before in posttest.
jannyHou
approved these changes
May 9, 2019
|
@slnode test please |
|
@harryadel, thanks for your contribution. Your PR has merged! 🎉 |
|
@dhmlau Yay, thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nspis longer supported, so instead of removing any security checks why not use thenpm audit?Checklist
guide