-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lts annoucement #79
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a second thought, I wonder how that Apr / Dec 2019 come up?
According to the node.js LTS schedule https://github.com/nodejs/Release,
Are the LTS schedules proposed in this PR based on the fact that we should allow some time for users to update to a more current version so it is not exactly matching the Node.js LTS schedule? If yes, I'm good with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was discussing EOL times with Chris and the rule for determining EOL is slightly different. We need to find all pairs of (Node version N.x, Module version M.x) that passed the following condition at some point in time: N.x was the latest LTS version of Node, M.x was the latest version of the module. For each of these pairs, M.x must be supported until N.x goes EOL.
So for example, because loopback-sdk-angular-cli 2.x was released in Dec 2015, after Node.js 4.x went LTS, we must assume that some people may have picked loopback-sdk-angular-cli 1.x to use with Node.js 4.x, an therefore loopback-sdk-angular-cli must be supported at least as long as Node.js 4.x is in LTS.
Here are the current LTS versions of Node.js:
When Node.js 6.x entered LTS, the latest angular-cli version was 2.x, therefore we need to support 2.x until April 2019.
When Node.js 8.x entered LTS, the latest angular-cli version was 3.x, therefore we need to support 3.x until Dec 2019.
There is no need to support 1.x version any more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 - no need to support 1.x version