Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hasOne relation DELETE, PATCH and PUT CRUD operations are missing #2233

Closed
RaphaelDrai opened this issue Jan 10, 2019 · 4 comments · Fixed by #2414
Closed

hasOne relation DELETE, PATCH and PUT CRUD operations are missing #2233

RaphaelDrai opened this issue Jan 10, 2019 · 4 comments · Fixed by #2414
Assignees
@RaphaelDrai
Labels
feature good first issue Relations Model relations (has many, etc.) Repository Issues related to @loopback/repository package

Comments

@RaphaelDrai
Copy link

Description / Steps to reproduce / Feature proposal

Add support hasOne CRUD Operations DELETE and PATCH

Initial reference:

#2147 (comment)

Acceptance Criteria

  • It requires a feature enhancement to support DELETE and PATCH CRUD operations in hasOne relation.
  • create interface for CRUD methods for DELETE and PATCH hasOne relation
  • create test cases
  • update docs
  • create a follow up issue to demonstrate using multiple relations in a new/existing example
@bajtos bajtos added feature Relations Model relations (has many, etc.) Repository Issues related to @loopback/repository package good first issue labels Jan 10, 2019
@b-admike
Copy link
Contributor

Thank you for taking this up @RaphaelDrai! Sorry I had started on it a while back and didn't get to finish. Feel free to use b403947 as inspiration/starting point.

@RaphaelDrai
Copy link
Author

Hello @b-admike,
it is my pleasure to contribute, no problem.
Thanks you so much for the information for the starting point reference.

@RaphaelDrai
Copy link
Author

Hello @b-admike,
I am starting to implement the DELETE first then I will continue with the PATCH and PUT operations.
I will change the title to add the PUT operation too.

@RaphaelDrai RaphaelDrai changed the title hasOne relation DELETE and PATCH CRUD operations are missing hasOne relation DELETE, PATCH and PUT CRUD operations are missing Jan 14, 2019
@dhmlau dhmlau added the TOB label Jan 22, 2019
RaphaelDrai pushed a commit to RaphaelDrai/loopback-next that referenced this issue Feb 6, 2019
feat(repository): delete operation in hasOne relation and example hasOne
9093ae0 
implemeted delete new feature on hasone relation. created an example of one to one application into
examples folder

"fix loopbackio#2233"
@RaphaelDrai RaphaelDrai mentioned this issue Feb 6, 2019
Closed
7 tasks
@RaphaelDrai
Copy link
Author

Hi @bajtos , @raymondfeng ,
I have added the new feature DELETE operation in hasOne relation and sent a pool request to merge it to the master.
Please do not close the issue #2233, I still need to provide the PATCH and PUT operations in the same issue.
Thanks a lot
Raphael

RaphaelDrai pushed a commit to RaphaelDrai/loopback-next that referenced this issue Feb 13, 2019
feat(repository): implement crud operations: delete, patch and put
5b926e6 
implement hasone relation operations delete, patch and put

"fix loopbackio#2233"
RaphaelDrai pushed a commit to RaphaelDrai/loopback-next that referenced this issue Feb 13, 2019
feat(repository): delete operation in hasOne relation and example hasOne
6d9db67 
implemeted delete new feature on hasone relation. created an example of one to one application into
examples folder

"fix loopbackio#2233"
RaphaelDrai pushed a commit to RaphaelDrai/loopback-next that referenced this issue Feb 13, 2019
feat(repository): implement crud operations: delete, patch and put
b55d55a 
implement hasone relation operations delete, patch and put

"fix loopbackio#2233"
RaphaelDrai pushed a commit to RaphaelDrai/loopback-next that referenced this issue Feb 17, 2019
feat(repository): implemented crud operations in hasone relation
cf226d5 
implemented the missing crud operations delete, patch and put operations

"fix loopbackio#2233"
@RaphaelDrai RaphaelDrai mentioned this issue Feb 17, 2019
Merged
7 tasks
RaphaelDrai pushed a commit to RaphaelDrai/loopback-next that referenced this issue Mar 11, 2019
feat(repository): hasone relation delete and patch
a3e77e8 
hasone relation with acceptance test implementation of delete and patch operations

"fix loopbackio#2233"
RaphaelDrai pushed a commit to RaphaelDrai/loopback-next that referenced this issue Mar 12, 2019
feat(repository): hasOne relation patch and delete operations
f780525 
implement patch and delete operations in hasOne relation

"fix loopbackio#2233"
RaphaelDrai pushed a commit to RaphaelDrai/loopback-next that referenced this issue Mar 17, 2019
feat(repository): hasone relation delete and patch operations
7c5163d 
implemented new feauture delete and patch operations in hasone relation

"fix loopbackio#2233"
bajtos pushed a commit to RaphaelDrai/loopback-next that referenced this issue Mar 19, 2019
@bajtos
feat(repository): implemented crud operations in hasone relation
d7d332e 
implemented the missing crud operations delete, patch and put operations

"fix loopbackio#2233"
bajtos pushed a commit to RaphaelDrai/loopback-next that referenced this issue Mar 19, 2019
@bajtos
feat(repository): hasone relation delete and patch
0dd3fd3 
hasone relation with acceptance test implementation of delete and patch operations

"fix loopbackio#2233"
bajtos pushed a commit to RaphaelDrai/loopback-next that referenced this issue Mar 19, 2019
@bajtos
feat(repository): hasOne relation patch and delete operations
b0b4cde 
implement patch and delete operations in hasOne relation

"fix loopbackio#2233"
bajtos pushed a commit to RaphaelDrai/loopback-next that referenced this issue Mar 19, 2019
@bajtos
feat(repository): hasone relation delete and patch operations
cc6da26 
implemented new feauture delete and patch operations in hasone relation

"fix loopbackio#2233"
@NorthDecoder NorthDecoder mentioned this issue Jan 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaphaelDrai RaphaelDrai

Labels
feature good first issue Relations Model relations (has many, etc.) Repository Issues related to @loopback/repository package
Projects
None yet
Milestone
No milestone
4 participants
@bajtos @b-admike @dhmlau @RaphaelDrai