feat(repository): hasOne relation patch and delete operations

implement patch and delete operations in hasOne relation

"fix loopbackio#2233"

packages/repository/src/__tests__/acceptance/has-one.relation.acceptance.ts

@@ -116,17 +116,13 @@ describe('hasOne relation', () => {
   });
 
   it('can PATCH hasOne instances', async () => {
-    //    existingCustomerId = 11;
     const address = await controller.createCustomerAddress(existingCustomerId, {
       street: '1 Amedee Bonnet',
       zipcode: '69740',
       city: 'Genas',
       province: 'Rhone',
     });
 
-    // const persisted = await addressRepo.findById(address.zipcode);
-    // expect(persisted.toObject()).to.deepEqual(address.toObject());
-
     const patchObject = {city: 'Lyon-Genas'};
     const arePatched = await controller.patchCustomerAddress(
       existingCustomerId,
@@ -135,10 +131,10 @@ describe('hasOne relation', () => {
 
     expect(arePatched).to.deepEqual({count: 1});
     const patchedData = await addressRepo.findById(address.zipcode);
-    expect(patchedData.city).to.containEql(address.city);
+    expect(patchedData.city).to.equal('Lyon-Genas');
   });
 
-  it('can throws error when query tries to change the foreignKey', async () => {
+  it('throws an error when PATCH tries to change the foreignKey', async () => {
     try {
       await expect(
         controller.patchCustomerAddress(existingCustomerId, {
@@ -149,17 +145,13 @@ describe('hasOne relation', () => {
   });
 
   it('can DELETE hasOne relation instances', async () => {
-    //    existingCustomerId = 12;
-    const address = await controller.createCustomerAddress(existingCustomerId, {
+    await controller.createCustomerAddress(existingCustomerId, {
       street: '1 Amedee Bonnet',
       zipcode: '69740',
       city: 'Genas',
       province: 'Rhone',
     });
 
-    const newData = await addressRepo.findById(address.zipcode);
-    expect(newData.city).to.containEql(address.city);
-
     const areDeleted = await controller.deleteCustomerAddress(
       existingCustomerId,
     );

packages/repository/src/model.ts

@@ -156,16 +156,6 @@ export class ModelDefinition {
     );
     return idProps;
   }
-
-  /**
-   * Returns the primary key(s) of a given model.
-   * Implemented by Raphael Drai for the purpose of PUT operations
-   * in relations models.
-   *
-   */
-  // idNames(): string[] {
-  //   return this.idProperties();
-  // }
 }
 
 function asJSON(value: any): any {

packages/repository/src/relations/has-one/has-one.repository.ts

@@ -42,15 +42,15 @@ export interface HasOneRepository<Target extends Entity> {
   ): Promise<Target>;
 
   /**
-   * Delete multiple target model instances
+   * Delete the related target model instance
    * @param where Instances within the where scope are deleted
    * @param options
    * @returns A promise which resolves the deleted target model instances
    */
   delete(where?: Where<Target>, options?: Options): Promise<Count>;
 
   /**
-   * Patch related target model instance
+   * Patch the  related target model instance
    * @param dataObject The target model fields and their new values to patch
    * @param options
    * @returns A promise which resolves the patched target model instances
@@ -119,7 +119,7 @@ export class DefaultHasOneRepository<
   ): Promise<Count> {
     const targetRepository = await this.getTargetRepository();
     return await targetRepository.updateAll(
-      dataObject,
+      constrainDataObject(dataObject, this.constraint),
       constrainWhere({}, this.constraint as Where<TargetEntity>),
     );
   }