This repository has been archived by the owner on Mar 13, 2020. It is now read-only.
[experimental] add integration with socket.io #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
requested review from
b-admike,
bajtos,
hacksparrow and
jannyHou
as code owners
7 tasks
emonddr
reviewed
May 16, 2019
| const server = new SocketIOServer({httpServerOptions: options.socketio}); | ||
| this.bind('servers.socketio.SocketIOServer').to(server); | ||
| /* | ||
| server.use((socket, next) => { |
There was a problem hiding this comment.
@raymondfeng , is this commented code block needed?
emonddr
approved these changes
May 16, 2019
|
hey @raymondfeng is there any news? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces loopbackio/loopback-next#2648
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈